Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Saevus Cor65 PCB #2075

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Add support for Saevus Cor65 PCB #2075

merged 2 commits into from
Nov 20, 2023

Conversation

mechlovin
Copy link
Contributor

Description

Add VIA support for Cor65 PCB made by Mechlovin.
Thanks.

QMK Pull Request

qmk/qmk_firmware#18872

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@Xelus22
Copy link
Collaborator

Xelus22 commented Nov 13, 2023

Hey @mechlovin , this ones a bit confusing in terms of tree structure of this keyboard. Is this Zed65 or Cor65?
Could you please clarify?

@mechlovin
Copy link
Contributor Author

Hi @Xelus22, this is Cor65 PCB, base on Zed65 - our 65% platform PCB.

@mechlovin
Copy link
Contributor Author

Should I change the name of PCB in info.json?

@Xelus22
Copy link
Collaborator

Xelus22 commented Nov 20, 2023

@mechlovin yeah it would be good if you could use the same tree structure as in QMK so its easier to differentiate between all the Zed65 variants?

like v3/mechlovin/zed65/no_backlight/cor65/cor65.json?

@mechlovin
Copy link
Contributor Author

Sure, thank you.

@mechlovin
Copy link
Contributor Author

Moved as your request.

@Xelus22 Xelus22 merged commit fa147f1 into the-via:master Nov 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xelus22 Xelus22 Xelus22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mechlovin @Xelus22